You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixes LeftSTAMPi so it behaves as an unsupervised series anomaly detector with empty fit. Im not sure this is the best way, but this is a genuine bug, so this solution stops unexpected behaviour for this wrapper.
predict(X) and fit_predict(X) now treat X as the complete stream being scored: STUMPi is initialized from the first n_init_train points, then updated over the remaining points. This avoids carrying state from a previous fit call into later predictions, returns scores with the correct length for the prediction series, and lets the standard series anomaly detector output check run again.
LeftSTAMPi exclusion from check_series_anomaly_detector_output was removed.
The behavioral change means fit(train).predict(test) no longer appends test onto the fitted training stream;
predict(test) scores test independently. Again, not sure this is best, we may need to add an update method to allow genuine streaming?
I have added the following labels to this PR based on the title: [ enhancement ].
I would have added the following labels to this PR based on the changes made: [ anomaly detection, testing ], however some package labels are already present.
The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.
If our pre-commit code quality check fails, please run pre-commit locally and push the fixes to your PR branch.
Don't hesitate to ask questions on the aeonDiscord channel if you have any.
PR CI actions
These checkboxes will add labels to enable or disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.
Run pre-commit checks for all files
Run mypy typecheck tests
Run all pytest tests and configurations
Run all notebook example tests
Run numba-disabled codecov tests
Disable numba cache loading
Regenerate expected results for testing
Push an empty commit to re-run CI checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anomaly detectionAnomaly detection packagebugSomething isn't workingenhancementNew feature, improvement request or other non-bug code enhancement
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TonyBagnall
requested review from
MatthewMiddlehurst and
SebastianSchmidl
as code owners
aeon-actions-bot
Bot
added
the
enhancement
Fixes #2819
Fixes LeftSTAMPi so it behaves as an unsupervised series anomaly detector with empty fit. Im not sure this is the best way, but this is a genuine bug, so this solution stops unexpected behaviour for this wrapper.
predict(X) and fit_predict(X) now treat X as the complete stream being scored: STUMPi is initialized from the first n_init_train points, then updated over the remaining points. This avoids carrying state from a previous fit call into later predictions, returns scores with the correct length for the prediction series, and lets the standard series anomaly detector output check run again.
LeftSTAMPi exclusion from check_series_anomaly_detector_output was removed.
The behavioral change means fit(train).predict(test) no longer appends test onto the fitted training stream;
predict(test) scores test independently. Again, not sure this is best, we may need to add an update method to allow genuine streaming?